Conditional rendering testing value of object of forward/backward link by jg10-mastodon-social · Pull Request #201 · pod-os/PodOS

jg10-mastodon-social · 2026-04-18T08:06:03Z

Closes #184

jg10-mastodon-social · 2026-04-18T12:23:57Z

+        `);
+  });
+
+  it('does not render templates when compareValue indicates that some-value-(lt|lte|gt|gte) is not met (numeric)', async () => {


I suspect we might need more tests here, but I'm not sure how to design them.
I designed these as TDD tests - they all fail if the numbers are treated as strings.

I've now grouped tests, and split out tests specifically of the test method.
I've tried to systematically go through possible combinations of inputs and data, using the it.each approach.

The code is still missing systematic tests of:

evaluating values of property and rev with multiple relations

evaluating values of property with multiple strings

evaluating values of property with multiple numbers

There are ad-hoc tests for this functionality, so given the difficulty in parameterising these combinatorial tests, I suggest we open an issue documenting this gap and merge in the mean time.

Any suggestions are welcome for systematically testing all combinations in the presence of multiple values!

…|lt|lte)

…ting bugs

…e relations

…string

…number

jg10-mastodon-social · 2026-05-31T06:24:11Z

 and this project adheres to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

+## 0.30.0


I think this is now 0.30.0, but I may have misunderstood what is in the previous release

jg10-mastodon-social · 2026-05-31T06:25:52Z


 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

+## 0.42.0


@angelo-v Is this correct?
When rebasing on main, it looked like your previous fixes no longer applied given the release in the mean time?

angelo-v

@jg10-mastodon-social Sorry, I just noticed I left some comments in "pending" state and you propbably did not see them. I am just submitting them now - yet I did not find the time to look at your latest changes, so I am not sure if they are still relevant. I am going to continue reviewing the current state later this week

angelo-v · 2026-05-20T20:35:29Z

    expect(page.root?.innerText).toEqualText('Video.');
  });
+
+  it.each([


suggestion: lets cover all cases as data-driven tests like that

issue: the commented out test cases are failing

This comment should now be fully addressed

angelo-v · 2026-05-20T20:36:36Z

    let state = null;
+    let values = null;
+
+    const compareValue = function (values: string[]): boolean {


issue: this function is very complex and should a) be refactored into smaller chunks and b) moved into its own file and heavily unit tested. Comparision logic be separated from element attributes.

I hadn't seen this comment and have therefore not refactored. Any help in dividing it up would be great!

I did however create a separate test file for this function so (b) is partially addressed.

I'm not sure about separating out comparison logic from element attributes - the main purpose of the function is to apply all necessary combinations of element attributes - the comparison logic itself is arguably trivial once the effect of the element attributes is applied.

angelo-v · 2026-05-20T20:38:58Z

    }
    if (caseElement.getAttribute('if-property') !== null) {
-      state = this.relations.map(x => x.predicate).includes(caseElement.getAttribute('if-property'));
+      const matchingRelations = this.relations.filter(x => x.predicate == caseElement.getAttribute('if-property'));


issue: same as above. Try to collect the relevant data and condition from component first, then do the logic in a dedicated function that is independent from the component and well tested

jg10-mastodon-social force-pushed the feat/conditional-values branch from 9c895fd to 243847e Compare April 18, 2026 08:14

jg10-mastodon-social commented Apr 18, 2026

View reviewed changes

Comment thread elements/src/components/pos-switch/pos-switch.spec.tsx Outdated

jg10-mastodon-social force-pushed the feat/conditional-values branch from 02ee964 to 25f0fef Compare April 27, 2026 00:54

jg10-mastodon-social marked this pull request as ready for review April 27, 2026 00:55

jg10-mastodon-social requested a review from angelo-v April 27, 2026 00:57

jg10-mastodon-social mentioned this pull request Apr 27, 2026

Reactivity to state changes #37

Open

angelo-v force-pushed the main branch from 8033535 to e2cd680 Compare May 9, 2026 23:13

angelo-v force-pushed the feat/conditional-values branch from 25f0fef to 261f92d Compare May 20, 2026 18:12

jg10-mastodon-social and others added 21 commits May 31, 2026 12:20

feat(pos-switch): if-property filters by some-value-eq

9770768

feat(pos-switch): if-rev filters by some-value-eq

aead175

feat(pos-switch): compareValue supports every-value-eq

598bb76

feat(Thing): add basic observeLiterals

1eca2ad

feat(Thing): observeLiterals updates after additions

d0ae499

feat(Thing): observeLiterals pushes updates in groups

205d72a

feat(Thing): observeLiterals ignores statements about other resources

688e391

feat(Thing): observeLiterals does not push if literals have not changed

57e2fd6

feat(pos-switch): if-property takes literals into account

0d9df94

chore(Thing): lint and typecheck

8887377

feat(pos-switch): compareValue supports (some|every)-value-(eq|gt|gte…

a106af2

…|lt|lte)

feat(pos-switch): compareValue supports numbers

857d5d1

test(pos-switch): add value-based example to integration test

d9c0313

doc(pos-case): add value testing attributes

57bccaa

doc(Thing): add doc string for observeLiterals

fc421db

doc(core): add observeLiterals to changelog

e4e3952

doc(elements): add pos-switch value testing to changelog

101b86c

doc: add pos-switch value testing to storybook

27891d7

refactor: generalize function to observe changes

36ef2e1

test(pos-switch): negation (absense) of property or backward link

afa327b

test(pos-switch): prepare data driven test for several conditions

3d6a895

angelo-v and others added 3 commits May 31, 2026 12:25

test(pos-switch): add more test cases, including failing ones highlig…

e66d556

…ting bugs

fix(core): export type Quad to prevent implicit type any

edac760

fix(pos-switch): not is applied after comparing values

69f0119

jg10-mastodon-social force-pushed the feat/conditional-values branch from 80772f3 to 69f0119 Compare May 31, 2026 02:25

jg10-mastodon-social added 12 commits May 31, 2026 12:32

test(pos-switch): not if-property some-value-eq passes

148570d

test(pos-switch): group tests; extract tests for test method

b58bd02

test(pos-switch): group reactivity tests

3384a2e

test(pos-switch): test if-typeof attribute combinations

83c6eaa

test(pos-switch): handle type checks with multiple values

699f066

test(pos-switch): if-property presence/absence combinatorial tests

fcfa10f

test(pos-switch): if-rev presence/absence combinatorial tests

7fa04f3

test(pos-switch): combinatorial tests for property and rev with singl…

958ffde

…e relations

test(pos-switch) combinatorial tests for property and rev with no values

bbb8943

test(pos-switch): combinatorial tests for property value with single …

d6b03d6

…string

test(pos-switch): combinatorial tests for property value with single …

4e5a20a

…number

chore(core): rebase CHANGELOG

9bbd066

jg10-mastodon-social commented May 31, 2026

View reviewed changes

angelo-v requested changes Jun 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conditional rendering testing value of object of forward/backward link#201

Conditional rendering testing value of object of forward/backward link#201
jg10-mastodon-social wants to merge 36 commits into
mainfrom
feat/conditional-values

jg10-mastodon-social commented Apr 18, 2026 •

edited by angelo-v

Loading

Uh oh!

jg10-mastodon-social Apr 18, 2026

Uh oh!

jg10-mastodon-social May 31, 2026

Uh oh!

Uh oh!

jg10-mastodon-social May 31, 2026

Uh oh!

jg10-mastodon-social May 31, 2026

Uh oh!

angelo-v left a comment

Uh oh!

angelo-v May 20, 2026

Uh oh!

jg10-mastodon-social Jun 9, 2026

Uh oh!

angelo-v May 20, 2026

Uh oh!

jg10-mastodon-social Jun 9, 2026

Uh oh!

angelo-v May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

		## 0.42.0

Conversation

jg10-mastodon-social commented Apr 18, 2026 • edited by angelo-v Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angelo-v left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jg10-mastodon-social commented Apr 18, 2026 •

edited by angelo-v

Loading